Merged
Conversation
khoshov
reviewed
May 29, 2025
| # ====================== | ||
| # SYSTEM DEPENDENCIES | ||
| # ====================== | ||
| RUN apt-get update && \ |
Owner
There was a problem hiding this comment.
RUN apt-get update && \
apt-get install -y --no-install-recommends curl gettext && \
apt-get clean && rm -rf /var/lib/apt/lists/*
khoshov
reviewed
May 29, 2025
Dockerfile
Outdated
| COPY --from=ghcr.io/astral-sh/uv:latest /uv /uvx /bin/ | ||
|
|
||
| # Ensure Python output is sent straight to terminal without buffering | ||
| ENV PYTHONUNBUFFERED=1 |
Owner
There was a problem hiding this comment.
ENV PYTHONUNBUFFERED=1 \
PYTHONDONTWRITEBYTECODE=1
khoshov
reviewed
May 29, 2025
| FROM python:3.13-slim-bookworm | ||
|
|
||
| # Install UV (ultra-fast Python package installer) from Astral.sh | ||
| COPY --from=ghcr.io/astral-sh/uv:latest /uv /uvx /bin/ |
Owner
There was a problem hiding this comment.
Зафиксировать версию UV
COPY --from=ghcr.io/astral-sh/uv:v0.1.33 /uv /uvx /bin/
khoshov
reviewed
May 29, 2025
config/settings.py
Outdated
| BASE_DIR = Path(__file__).resolve().parent.parent | ||
|
|
||
| # SECURITY WARNING: don't run with debug turned on in production! | ||
| SECRET_KEY = DJANGO_SECRET_KEY |
Owner
There was a problem hiding this comment.
Я бы сделал сразу
SECRET_KEY = os.getenv("DJANGO_SECRET_KEY")
khoshov
reviewed
May 29, 2025
config/settings.py
Outdated
|
|
||
| # SECURITY WARNING: don't run with debug turned on in production! | ||
| SECRET_KEY = DJANGO_SECRET_KEY | ||
| DEBUG = True |
Owner
There was a problem hiding this comment.
Заменить на переменную окружения
BerdyshevEugene
force-pushed
the
feature/add_docker_and_doker_compose
branch
from
5fc910b to
294f11a
Compare
khoshov
approved these changes
Jun 15, 2025
config/settings.py
Outdated
| SECRET_KEY = DJANGO_SECRET_KEY | ||
| DEBUG = True | ||
|
|
||
| ALLOWED_HOSTS = [] |
Owner
There was a problem hiding this comment.
Заменить на переменную окружения
| # Database | ||
| # https://docs.djangoproject.com/en/5.2/ref/settings/#databases | ||
|
|
||
| DATABASES = { |
Owner
There was a problem hiding this comment.
Заменить на переменную окружения
| description = "Add your description here" | ||
| requires-python = ">=3.13" | ||
| dependencies = [ | ||
| "django-ckeditor-5==0.2.17", |
Owner
There was a problem hiding this comment.
Пока должны остаться только
django-environ
django
psycopg2-binary
| # Static files (CSS, JavaScript, Images) | ||
| # https://docs.djangoproject.com/en/5.2/howto/static-files/ | ||
|
|
||
| # ============= |
Owner
There was a problem hiding this comment.
Прогнать настройки через LLM (отформатировать)
| - .env | ||
| volumes: | ||
| - ./:/app | ||
| - /app/.venv |
| # ====================== | ||
| # SYSTEM DEPENDENCIES | ||
| # ====================== | ||
| RUN apt-get update && \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.